Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSHINT] Unnecessary semicolon fixed in all files #1533

Closed
wants to merge 1 commit into from
Closed

[JSHINT] Unnecessary semicolon fixed in all files #1533

wants to merge 1 commit into from

Conversation

ainthek
Copy link
Contributor

@ainthek ainthek commented Feb 4, 2015

if you don't mind, I have fixed also other files for this one bug.

May continue with other, or even include .jshintrc based on your style (if interested)

@dasilvacontin
Copy link
Contributor

We are definitely interested in include style checks in our test/CI. I've been looking forward to suggest a .jshintrc over #1359, but I've been a bit busy lately. Could you come by the issue and suggest some settings?

@dasilvacontin
Copy link
Contributor

(btw, you are using two different users in GitHub?)

@ainthek
Copy link
Contributor Author

ainthek commented Feb 5, 2015

Hi felix, yes and sorry, I use several accounts depending where I sit and where I forget to change my git settings in keychain or display names in git config. Sorry again... hope it does not matter so much.

I vote for .jshint as, can make package.json changes, make npm run jslint script part of package json, and make jshint fitting your current style or take felines, well but what exactly do you prefer ?

@ainthek
Copy link
Contributor Author

ainthek commented Feb 5, 2015

Ignore this pull request please, it fixes not source but generated file. Will make a new fix, sorry.

@ainthek ainthek closed this Feb 5, 2015
@ainthek ainthek deleted the fixes branch February 5, 2015 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants