Ban mixing of promise and async APIs in it handler.
#1735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `it` handler accepts a `done` argument, it is using the async API, and must not return a promise. Closes mochajs#1734.
jbnicolai
force-pushed
the
master
branch
3 times, most recently
from
2f458ab
to
2952eca
Compare
| @@ -238,6 +238,9 @@ Runnable.prototype.run = function(fn){ | |||
| } | |||
| done(); | |||
| }); | |||
| if (ret && typeof ret.then === 'function') { | |||
| done(new Error('runnable accepted "done" but returned promise')); | |||
There was a problem hiding this comment.
this needs different language.
There was a problem hiding this comment.
how about Supply a "done" parameter or return a Promise, but not both
then I think we're good to merge |
|
This was handled in #1320, closing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
ithandler accepts adoneargument, it is using the asyncAPI, and must not return a promise.
Closes #1734.