Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1766: stackfilter should not ignore node_modules #1767

Closed
wants to merge 1 commit into from
Closed

Fix 1766: stackfilter should not ignore node_modules #1767

wants to merge 1 commit into from

Conversation

danielstjules
Copy link
Contributor

Fix for #1766

@jbnicolai
Copy link

👍 from me.

@boneskull
Copy link
Member

I'm on mobile so difficult to see--but if this ensures anything in Mocha's own node_modules is still hidden, go ahead and merge.

@jbnicolai jbnicolai force-pushed the master branch 3 times, most recently from 2f458ab to 2952eca Compare July 5, 2015 10:25
@danielstjules
Copy link
Contributor Author

Weird. I don't remember merging this...

Edit: haha nvm, thanks @jbnicolai
And @boneskull, it still results in mocha's own node_modules being hidden

@danielstjules danielstjules deleted the fix-1766 branch July 6, 2015 06:01
@jbnicolai
Copy link

@danielstjules I merged it, and amended the message to reference and close this issue. GH should be more transparant about this..

@danielstjules
Copy link
Contributor Author

No worries, appreciate it! :)

@kpdecker
Copy link

Is this released? Just spent lost numerous hours fighting what I thought were source map issues only to finally find that it was this root issue.

@danielstjules
Copy link
Contributor Author

Not yet, no. It will be in the next minor release. Sorry for the inconvenience.

@kpdecker
Copy link

Thanks, I hacked around it locally for now. Completely understand the lag time between fix and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants