Fix: html-runner crashing because of missing process.stdout shim #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running mocha in the browser you get a crash in the following code:
if (isatty) {
exports.window.width = process.stdout.getWindowSize
? process.stdout.getWindowSize(1)[0]
: tty.getWindowSize()[1];
}
That is because we need to shim the process.stdout before requiring
mocha from browser-entry.js, I fixed that by moving it to the top of the
file.
jbnicolai
pushed a commit
that referenced
this pull request
Jul 6, 2015
Fix: html-runner crashing because of missing process.stdout shim
|
Thank you very much. This again stresses the importance of #1732 and manual HTML reporter testing until then. |
|
@jbnicolai happy I could help :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1789
When running mocha in the browser you get a crash in the following code:
That is because we need to shim the process.stdout before requiring
mocha from browser-entry.js, I fixed that by moving it to the top of the
file.