Fix an issue when describe and xdescribe fail without a callback (#1744)

[antoval]

Now describe fails with a helpful error message whereas xdescribe doesn't execute the callback if it's not supplied.

Closes #1744.

[dasilvacontin]

Hi, thanks for the PR!

You shouldn't build mocha.js, that is only done when a release is prepared by one of the maintainers.

Also, @mochajs/mocha, is callback the appropriate word here? Or is something like 'suite definition' used?

[antoval]

Hey!

Thanks for the prompt feedback! I should probably revert changes to mocha.js? Suite definition does sound more appropriate, I would change that as well.

[dasilvacontin]

No problemo!

Yep, the PR should have no changes on mocha.js. Regarding the suite definition improvement, you could add it already, but I'd first like to know the other maintainers' opinion before merging.

[danielstjules]

Thanks for the PR antoval! :) Definitely a helpful change, though it would need to target 3.0.0 like #1809

Beyond that, I think it would be worth implementing this change across all interfaces (not just BDD) to be consistent.

[dasilvacontin]

ping @antoval

[antoval]

Sorry for a long delay, didn't have a chance to spend more time with this due to traveling. I'm back soon and will make the changes mentioned above, should be quick.

[antoval]

I followed the suggestions above and did the changes against the 3.0.0 release as well as changed the wording ('callback' vs 'suite definition'). I have one question before I commit my changes though. @danielstjules, I checked other interfaces (TDD and qunit). I did the same changes to TDD's suite() whereas qunit's suite() doesn't require a function callback, thus no changes need to be done. Am I missing anything here? Thanks!

[hollomancer]

Will need to be rebased.

[hollomancer]

We'll get this added!

[boneskull]

added 3a2dae8

[boneskull]

merged as e22c407 less mocha.js changes. @antoval thanks!!