Upgrade Jade dependency to 1.11.0 #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order for variables definition is wrong in 3f78f10, so, html coverage page print `<undefined></undefined>` because str is undefined in `jade.compile(str, { filename: file });`.
Jade syntax isn't broken in new version, but update some syntax for being more explicitly. fix mochajs#1811
|
@outsideris thanks |
|
this looks good to me as per manual test |
boneskull
added a commit
that referenced
this pull request
Aug 16, 2015
Upgrade Jade dependency to 1.11.0
|
@boneskull Thank you. I can fix it as you provide guide and history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1811 .
There is a error for html-cov. I fixed it, and then I updated jade.