avoid double and tripple xUnit XML escaping #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Otherwise the title gets triple escaped and the error gets double escaped <testcase classname="ex-name" name="should do a thing" time="0.12"><failure><![CDATA[(a =&gt; b + &quot;c&quot;); failed
Error: (a => b + "c");
at Object.<anonymous> (./foo.js:80:19)]]></failure></testcase>
</testsuite> |
|
@danielstjules bump |
|
@dasilvacontin bump |
| */ | ||
|
|
||
| function cdata(str) { | ||
| return '<![CDATA[' + escape(str) + ']]>'; |
There was a problem hiding this comment.
Where did the CDATA tag go?
There was a problem hiding this comment.
graingert
force-pushed
the
prevent-double-tripple-escaping
branch
from
d053a37
to
c7074c4
Compare
|
Okay, without the Otherwise LGTM. But hopefully we can get a reply soon. |
|
Will locally rebase && test in a few hours and merge if all is good. |
|
Sauce passed when ran from local. Merging. Thanks @graingert! :) |
|
Sweet do you know when this will get a release? |
|
@graingert Now available on npm. ;) (v2.5.2) |
This was referenced Sep 23, 2018
This was referenced Dec 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.