Fix/improve es3 compat #2305
Closed
Fix/improve es3 compat #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll squash my contribution |
boneskull
force-pushed
the
fix/improve-es3-compat
branch
from
d52f2d5
to
9ac4a2d
Compare
|
Looks good to me. |
|
Any reason
? |
|
Would they be used in-browser in any way? |
|
@ScottFreeCode maybe headlessly. |
|
@ScottFreeCode in the future you can simply rebase the branch onto |
boneskull
force-pushed
the
fix/improve-es3-compat
branch
from
b9e9631
to
add08ad
Compare
|
I do generally rebase my own branches rather than merging updates; in this case I just wasn't sure if I should mess with ndhoule's commit. Either way, looks like this is ready to roll? (Or as ready as it will be once we work out any unrelated Windows/AppVeyor kinks... EDIT: Actually, looks like AppVeyor's not passing simply because it's turned on for the project but hasn't been added to this code yet at all.) |
boneskull
force-pushed
the
fix/improve-es3-compat
branch
from
add08ad
to
d7c459b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2259 for original PR.