Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sauce key to JWT #2603

Closed
wants to merge 2 commits into from
Closed

Conversation

ScottFreeCode
Copy link
Contributor

I figure we'll test whether this works for a PR, then look at the branch and test whether it works for non-PR commits before merging into master, and if both those work then we can consider #2602 handled.

We'll find out whether that's correct or if we have to put it under `env` or duplicate it or something.
@ScottFreeCode
Copy link
Contributor Author

Clearly I missed something, as this isn't getting all the Sauce credential stuff it's looking for: https://travis-ci.org/mochajs/mocha/jobs/179248317#L876

@ScottFreeCode
Copy link
Contributor Author

Hmm. Even with SAUCE_USERNAME separately set, it's still getting this: https://travis-ci.org/mochajs/mocha/jobs/179251815#L876 Maybe it needs the SAUCE_ACCESS_KEY alone re-encrypted (because the old encrypted setting contained both)?

@dasilvacontin
Copy link
Contributor

Maybe it needs the SAUCE_ACCESS_KEY alone re-encrypted (because the old encrypted setting contained both)

Sounds likely!

@boneskull
Copy link
Member

@ScottFreeCode SAUCE_USERNAME and SAUCE_ACCESS_KEY is also in the settings which may be conflicting?

@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. qa labels Dec 2, 2016
@boneskull
Copy link
Member

This is likely superceded by #2861.

@boneskull boneskull closed this Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants