Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue #2628 allowing to override the default test suite name of… #2676

Merged
merged 3 commits into from Sep 28, 2017
Merged

Fixing issue #2628 allowing to override the default test suite name of… #2676

merged 3 commits into from Sep 28, 2017

Conversation

ngeor
Copy link
Contributor

@ngeor ngeor commented Jan 19, 2017

Fixing issue #2628 allowing to override the default test suite name of the xunit reporter.

@jsf-clabot
Copy link

jsf-clabot commented Jan 19, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 76.82% when pulling bf88a21 on ngeor:xunit-custom-suite-name-2628 into 52a1957 on mochajs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 88.209% when pulling 2571d8d on ngeor:xunit-custom-suite-name-2628 into a2fc76c on mochajs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 88.209% when pulling d576434 on ngeor:xunit-custom-suite-name-2628 into a2fc76c on mochajs:master.

@drazisil drazisil added type: feature enhancement proposal status: needs review a maintainer should (re-)review this pull request labels Mar 30, 2017
@boneskull boneskull added semver-minor implementation requires increase of "minor" version number; "features" to-merge and removed status: needs review a maintainer should (re-)review this pull request labels Jul 31, 2017
@boneskull
Copy link
Member

this looks good. it should go into v3.6.0 or v4.0.0, whichever comes first.

@boneskull
Copy link
Member

@ngeor thanks!

@ScottFreeCode
Copy link
Contributor

Should we update the assertion library in this to be the same one used by the existing tests for this reporter, or should we merge and update to use the same assertion library afterward?

@boneskull boneskull merged commit de68250 into mochajs:master Sep 28, 2017
@boneskull boneskull added this to the v4.0.0 milestone Sep 28, 2017
@plroebuck plroebuck mentioned this pull request Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-minor implementation requires increase of "minor" version number; "features" type: feature enhancement proposal
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ngeor @jsf-clabot @coveralls @boneskull @ScottFreeCode @drazisil