Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure mocha -h consistently shows help #2746

Merged
merged 6 commits into from Oct 18, 2017
Merged

Make sure mocha -h consistently shows help #2746

merged 6 commits into from Oct 18, 2017

Commits on Oct 17, 2017

  1. Make sure mocha -h consistently shows help 

    Previously, having options in `test/mocha.opts` would add those to `process.argv` to be passed to `program.parse`, which would make it stop showing help.

Fixes mochajs#2745
    @Zarel
    Zarel committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    d98abd3 View commit details
    Browse the repository at this point in the history

  2. Add tests for mocha -h fix

    @Zarel
    Zarel committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    46112fa View commit details
    Browse the repository at this point in the history

  3. Improve test for mocha -f fix

    @Zarel
    Zarel committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    cb6b159 View commit details
    Browse the repository at this point in the history

  4. Try using the helpers to invoke Mocha; this will require using the cu… 

    …rrent working directory, so make test/mocha.opts be available if necessary without overwriting existing one if any
    @ScottFreeCode @Zarel
    ScottFreeCode authored and Zarel committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    8621eb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2017

  1. Fix test so that it actually proves the behavior with the right mocha… 

    ….opts
    @ScottFreeCode
    ScottFreeCode committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    da32727 View commit details
    Browse the repository at this point in the history

  2. Fix linting [ci skip]

    @ScottFreeCode
    ScottFreeCode committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    1cb9f90 View commit details
    Browse the repository at this point in the history