Move linting into an npm script. Relates to #2805 #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 17a1770 on npm-script-lint into ** on master**. |
ScottFreeCode
approved these changes
May 16, 2017
|
@Munter why the |
|
@dasilvacontin I was assuming it means this is ready to merge in. But it's probably easier for the next person finishing up a realease to do it, since they won't have to hunt down changes in reverse from the git log |
|
@Munter Hmm, I think it's simpler to merge directly. Simpler, less rules to follow, less assumptions to make. I'd prefer to enforce all changes to go through PRs, so when doing the reverse scan on the git log I can safely focus only on the merge commits. Also, if you wait to merge a bunch of PRs in one go, there could be conflicts. That would be horrible. 🤔 |
|
Yeah, didn't think that all the way through |
|
All good. 😊 |
This was referenced Nov 13, 2018
This was referenced Dec 6, 2018
This was referenced Dec 23, 2018
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
Move linting into an npm script. Relates to mochajs#2805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.