Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodash.create #2978

Closed
wants to merge 1 commit into from
Closed

Update lodash.create #2978

wants to merge 1 commit into from

Conversation

bdsomer
Copy link

@bdsomer bdsomer commented Sep 2, 2017

As you can see through this visualization, updating lodash.create would drastically reduce the number of dependencies that mocha has, causing faster install times and occupying less disk space.

@jsf-clabot
Copy link

jsf-clabot commented Sep 2, 2017

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 89.062% when pulling f9f90f8 on bdsomer:patch-1 into 075bd51 on mochajs:master.

@ScottFreeCode
Copy link
Contributor

Thanks for the PR! This sounds really helpful; I was looking for ways to cut down on install time not too long ago.

To be sure the new version works in all the environments Mocha supports, I think we'll want to rebase this after we get the JWT stuff for SauceLabs set up so that the Travis jobs are actually testing all the browsers (whereas right now there's a separate job for each browser but for PRs from forks they redundantly test PhantomJS instead).

@bdsomer
Copy link
Author

bdsomer commented Sep 3, 2017

@ScottFreeCode Okay, sounds good!

@boneskull
Copy link
Member

See #2979; lodash.create may be able to be dropped when that happens.

@boneskull
Copy link
Member

boneskull commented Sep 28, 2017

linking this to #3018. (implying that this can likely be closed and we can drop lodash.create altogether when I get to #3018)

@boneskull
Copy link
Member

ok, we don't need this. thanks anyhow!

@boneskull boneskull closed this Sep 29, 2017
@bdsomer
Copy link
Author

bdsomer commented Sep 29, 2017

@boneskull Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants