Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AMD bundle by hacking around check in he module; closes #3000 #3001

Merged
merged 1 commit into from Sep 10, 2017
+4 −2
Merged

fix AMD bundle by hacking around check in he module; closes #3000 #3001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions scripts/dedefine.js
View file
Open in desktop
Expand Up @@ -6,8 +6,7 @@
*/

var through = require('through2');
var defineRx = /typeof define === ['"]function['"] && define\.amd/g;

var defineRx = /typeof\s+define\s*===?\s*['"]function['"]\s*&&\s*(?:define\.amd|typeof\s+define\.amd\s*===?\s*['"]object['"]\s*&&\s*define\.amd)/g;
function createStream () {
return through.obj(function (chunk, enc, next) {
this.push(String(chunk)
Expand Down
3 changes: 3 additions & 0 deletions scripts/travis-before-script.sh
View file
Open in desktop
Expand Up @@ -2,3 +2,6 @@

# bundle artifacts to AWS go here
mkdir -p .karma

# ensure we are building a non-broken bundle for AMD
make BUILDTMP/mocha.js && [[ -z "$(grep 'define.amd' BUILDTMP/mocha.js)" ]] || exit 1