Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default from forced exit to no-exit #3034

Merged
merged 2 commits into from Oct 1, 2017
Merged

Switch default from forced exit to no-exit #3034

merged 2 commits into from Oct 1, 2017

Conversation

ScottFreeCode
Copy link
Contributor

Allows --exit to override and force exit as before. Resolves #2879

@ScottFreeCode ScottFreeCode added the semver-major implementation requires increase of "major" version number; "breaking changes" label Sep 29, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.177% when pulling a3e32de on issue/2879 into 8b79c5d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.177% when pulling 2b6991f on issue/2879 into 0f816ac on master.

boneskull
boneskull reviewed Sep 29, 2017
View reviewed changes
Copy link
Member

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure browser users can do this too somehow

@boneskull
Copy link
Member

Also, wait, does this actually work, just by changing it like that?

@ScottFreeCode
Copy link
Contributor Author

This doesn't affect the browser one way or the other as it's purely the Node CLI process.exit call.

@ScottFreeCode
Copy link
Contributor Author

And yeah, I think so -- just alter the Commander line and it switches the default value.

@boneskull boneskull mentioned this pull request Sep 30, 2017
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.436% when pulling 69c1e54 on issue/2879 into c5d69e0 on master.

@boneskull boneskull merged commit fa228e9 into master Oct 1, 2017
@boneskull boneskull deleted the issue/2879 branch October 1, 2017 02:18
@boneskull boneskull added this to the v4.0.0 milestone Oct 1, 2017
@boneskull boneskull removed their assignment Dec 12, 2017
@medikoo medikoo mentioned this pull request May 16, 2019
Merged
@bcoe bcoe mentioned this pull request Jul 16, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boneskull boneskull boneskull left review comments

Assignees
No one assigned
Labels
semver-major implementation requires increase of "major" version number; "breaking changes"
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ScottFreeCode @coveralls @boneskull