Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have Base generate the strings for error messages immediately #3075

Merged
merged 3 commits into from Dec 7, 2017
Merged

have Base generate the strings for error messages immediately #3075

merged 3 commits into from Dec 7, 2017

Commits on Oct 20, 2017

  1. have Base generate the strings for error messages immediately instead… 

    … of delaying until epilogue, the reason for this is that it is possible to reference objects in errors that could be mutated after the error occurs, causing the printed error message to be misleading
    @abrady0
    abrady0 committed Oct 20, 2017
    Copy the full SHA
    09226eb View commit details
    Browse the repository at this point in the history

  2. re-add stringify during list to appease tests, open for discussion if… 

    … this is correct behavior
    @abrady0
    abrady0 committed Oct 20, 2017
    Copy the full SHA
    760b4db View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Merge branch 'master' into master

    @boneskull
    boneskull committed Dec 7, 2017
    Copy the full SHA
    24b65e8 View commit details
    Browse the repository at this point in the history