fix: When using --delay, .only() no longer works. Issue #1838 #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
this looks good, thank you! |
boneskull
added
type: bug
boneskull
reviewed
Jan 28, 2018
| it.only('should run this', function () {}); | ||
|
|
||
| it('should not run this test, neither', function () { | ||
| (true).should.equal(false); |
There was a problem hiding this comment.
we aren't using should any longer, and assert isn't actually used here either, but I'll clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Fix the issue #1838
Why should this be in core?
Benefits
Possible Drawbacks
Applicable issues
It applies to issue #1838
It is bug fix