Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add working wallaby config #3224

Merged
merged 1 commit into from Feb 8, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 49 additions & 0 deletions wallaby.js
@@ -0,0 +1,49 @@
'use strict';

module.exports = () => {
return {
files: [
'index.js', 'lib/**/*.js', 'test/setup.js',
{
pattern: 'test/node-unit/**/*.fixture.js',
instrument: false
}, {
pattern: 'test/unit/**/*.fixture.js',
instrument: false
}
],
filesWithNoCoverageCalculated: ['test/**/*.fixture.js'],
tests: [
'test/unit/**/*.spec.js', 'test/node-unit/**/*.spec.js'
],
env: {
type: 'node',
runner: 'node'
},
workers: {recycle: true},
testFramework: {type: 'mocha', path: __dirname},
setup (wallaby) {
// running mocha instance is not the same as mocha under test,
// running mocha is the project's source code mocha, mocha under test is instrumented version of the source code
const runningMocha = wallaby.testFramework;
runningMocha.timeout(200);
// to expose it/describe etc. on the mocha under test
const mochaUnderTest = new (require('./'))();
mochaUnderTest.suite.emit('pre-require', global, '', mochaUnderTest);
// to make test/node-unit/color.spec.js pass, we need to run mocha in the project's folder context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArtemGovorov how did you figure this out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had been reading mocha source code and discovered it. Wallaby uses mocha a bit differently from how mocha CLI is using mocha :)

const childProcess = require('child_process');
const execFile = childProcess.execFile;
childProcess.execFile = function () {
let opts = arguments[2];
if (typeof opts === 'function') {
opts = {};
Array.prototype.splice.call(arguments, 2, 0, opts);
}
opts.cwd = wallaby.localProjectDir;
return execFile.apply(this, arguments);
};
require('./test/setup');
},
debug: true
};
};