Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3354: Annotate when exceptions are caught but ignored #3356

Merged
merged 7 commits into from May 1, 2018
Merged

#3354: Annotate when exceptions are caught but ignored #3356

merged 7 commits into from May 1, 2018

Commits on Apr 26, 2018

  1. Merge pull request #1 from mochajs/master 

    Update from upstream
    @plroebuck
    plroebuck committed Apr 26, 2018
    Copy the full SHA
    8d6a1eb View commit details
    Browse the repository at this point in the history

  2. style(*various*): Annotate when exceptions are caught but ignored 

    There's an existing convertion to name intentionally ignored errors in catch block as `ignore`.
Modified codebase to follow it.

Fixes mochajs#3354
    @plroebuck
    plroebuck committed Apr 26, 2018
    Copy the full SHA
    68b3596 View commit details
    Browse the repository at this point in the history

  3. style(bin/options.js): Turn off prettier for single line 

    Prettier reformatting is just wrong here. fs.readFileSync() should **not** be split across multiple
lines.
    @plroebuck
    plroebuck committed Apr 26, 2018
    Copy the full SHA
    eb034dd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2018

  1. Merge branch 'master' into issue/3354

    @boneskull
    boneskull committed Apr 27, 2018
    Copy the full SHA
    9be70b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2018

  1. Revert "style(bin/options.js): Turn off prettier for single line" 

    This reverts commit eb034dd.
    @plroebuck
    plroebuck committed Apr 28, 2018
    Copy the full SHA
    62be918 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue/3354' of https://github.com/plroebuck/mocha into … 

    …issue/3354
    @plroebuck
    plroebuck committed Apr 28, 2018
    Copy the full SHA
    9daaa5c View commit details
    Browse the repository at this point in the history

  3. style(bin/options.js): Revert un-Prettier comment per Boneskull's req… 

    …uest
    @plroebuck
    plroebuck committed Apr 28, 2018
    Copy the full SHA
    792b340 View commit details
    Browse the repository at this point in the history