Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs with latest cli options #3432

Merged
merged 1 commit into from Jul 22, 2018

Conversation

outsideris
Copy link
Member

In docs, CLI usage is outdated.
I updated them with current CLI options.

Signed-off-by: Outsider <outsideris@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.289% when pulling 0ca6db9 on outsideris:update-cli-usage into 59d5850 on mochajs:master.

Copy link
Contributor

@markowsiak markowsiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where the defaults provided, but do we need emptied defaults where none are supplied?

  • compilers
  • globals

@outsideris
Copy link
Member Author

@markowsiak
They are from here. Empty list([]) is showed like empty.

I like to not show default: or show default: [].

I feel it is another issue. So, I open a issue for it.

@outsideris outsideris added the area: documentation anything involving docs or mochajs.org label Jul 16, 2018
Copy link
Contributor

@markowsiak markowsiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tracking the separate issue 👍

@outsideris outsideris merged commit 7941c9e into mochajs:master Jul 22, 2018
-w, --watch watch files for changes
--check-leaks check for global variable leaks
--full-trace display the full stack trace
--compilers <ext>:<module>,... use the given module(s) to compile files
--compilers <ext>:<module>,... use the given module(s) to compile files (default: )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand why you merged this with the obvious fix not done.
Add [] back as the default value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you leave comments here?
This PR was to update doc because it is outdated. So, we found [] problem here.
I will update them in #3529 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let comments here because this is where the other half of the "commander" problem went.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, this PR just update our docs.
The real problem is mocha binary print like that, not docs.
At that time, somebody asked why some flags are missing in the document. So, I found the issue when I make this PR. I separated the PR because this PR is for making the document up-to-date.

--debug-brk enable node's debugger breaking on the first line
--globals <names> allow the given comma-delimited global [names]
--globals <names> allow the given comma-delimited global [names] (default: )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [] back as the default value.

--delay wait for async suite definition
--allow-uncaught enable uncaught errors to propagate
--forbid-only causes test marked with only to fail the suite
--forbid-pending causes pending tests and test marked with skip to fail the suite
--file <file> include a file to be ran during the suite (default: )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [] back as the default value.

--delay wait for async suite definition
--allow-uncaught enable uncaught errors to propagate
--forbid-only causes test marked with only to fail the suite
--forbid-pending causes pending tests and test marked with skip to fail the suite
--file <file> include a file to be ran during the suite (default: )
--exclude <file> a file or glob pattern to ignore (default: )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [] back as the default value.

@@ -740,7 +740,6 @@ Mocha supports the `err.expected` and `err.actual` properties of any thrown `Ass
```text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup here should probably be "```console" as we're showing screen output.

Copy link
Contributor

@plroebuck plroebuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure why you merged this; it contains as many problems as it solved.

Myself, I always just ran the project binary with --help to ensure the "README" help matched.
It was ofttimes illuminating what had gotten screwed up.
Perhaps Mocha should follow the same process.

Please make the requested corrections.

@outsideris
Copy link
Member Author

I don't understand what you point out.
This is current mocha's help.

@plroebuck
Copy link
Contributor

Nvm. I guess I see what you did now.

@boneskull boneskull added this to the v6.0.0 milestone Nov 5, 2018
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants