Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong use of to throw that will fail with unexpected v11 #3648

Merged
merged 1 commit into from Jan 3, 2019
Merged

Fixed wrong use of to throw that will fail with unexpected v11 #3648

merged 1 commit into from Jan 3, 2019

Commits on Jan 3, 2019

  1. Fixed wrong use of to throw that will fail with unexpected v11 

    I was testing Mocha's compatibility with the upcoming version of Unexpected. For
that version we remove support for satisfy against a function as that has
confused people. I found one test that will fail with the next version as it was
using to throw to satisfy against an error. This test will actually just call
TypeError with the throw error, so it wont really check anything. This PR fixes
the test to assert that the throw error is a TypeError.
    @sunesimonsen
    sunesimonsen committed Jan 3, 2019
    Copy the full SHA
    f57a904 View commit details
    Browse the repository at this point in the history