Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lookupFiles and files #3722

Merged
merged 13 commits into from Feb 13, 2019
Merged

Refactor lookupFiles and files #3722

merged 13 commits into from Feb 13, 2019

Commits on Feb 8, 2019

  1. refactor(lib/utils.js): Extract lookupFile conditions into functions

    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    8004f71 View commit details
    Browse the repository at this point in the history

  2. refactor(lib/utils.js): Rename variables to match intent

    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    c6b16e9 View commit details
    Browse the repository at this point in the history

  3. refactor(lib/utils.js): Make variable scope more apparent

    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    3ab1f24 View commit details
    Browse the repository at this point in the history

  4. refactor(lib/utils.js): Rename variables to match intent (exports.files)

    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    5546786 View commit details
    Browse the repository at this point in the history

  5. refactor(lib/utils.js): Replace with path.join, fix @param document… 

    …ation
    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    206b2d6 View commit details
    Browse the repository at this point in the history

  6. refactor(lib/utils.js): Replace export.files RE with `hasMatchingEx… 

    …tname`

Replacement should work faster (re.test() faster than string.match()).
    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    75a4509 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. refactor(lib/utils.js): Minor tweaks 

    Ordered requires (node,third party,internal). Fixed docstring. Added comments.
    @plroebuck
    plroebuck committed Feb 9, 2019
    Copy the full SHA
    9b5413d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Merge branch 'master' into plroebuck/refactor-lookupFiles

    @plroebuck
    plroebuck committed Feb 11, 2019
    Copy the full SHA
    f70f1d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. docs(lib/utils.js): Add JSDoc for inherits.

    @plroebuck
    plroebuck committed Feb 12, 2019
    Copy the full SHA
    8094b63 View commit details
    Browse the repository at this point in the history

  2. docs(lib/utils.js): Fixup JSDoc for createMap and defineConstants

    @plroebuck
    plroebuck committed Feb 12, 2019
    Copy the full SHA
    895862c View commit details
    Browse the repository at this point in the history

  3. refactor(lib/utils.js): Refactor ignored 

    Renamed as `considerFurther` since result was opposite of existing name. Added appropriate JSDoc for
function. Made `ignore` variable function scope.
    @plroebuck
    plroebuck committed Feb 12, 2019
    Copy the full SHA
    a1599d9 View commit details
    Browse the repository at this point in the history

  4. docs(lib/utils.js): Document functions that throw

    @plroebuck
    plroebuck committed Feb 12, 2019
    Copy the full SHA
    b82d65d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. refactor(lib/utils.js): Replace hasMatchingExtname implementation 

    Swapped out the `RegExp.test` implementation for `Array.some` one, providing ~3.5x speedup.
    @plroebuck
    plroebuck committed Feb 13, 2019
    Copy the full SHA
    6f96594 View commit details
    Browse the repository at this point in the history