Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs Amend JS Foundation to OpenJS Foundation (#3971) #4044

Closed
wants to merge 4 commits into from
Closed

docs Amend JS Foundation to OpenJS Foundation (#3971) #4044

wants to merge 4 commits into from

Conversation

leehwarang
Copy link

Description of the Change

JS Foundation has been modified to remain unaltered as OpenJS Foundation. (#3971)

@jsf-clabot
Copy link

jsf-clabot commented Oct 4, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

outsideris
outsideris approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.
We missed them during adress mochajs/admin#7

LICENSE Outdated
@@ -1,6 +1,7 @@
(The MIT License)

Copyright (c) 2011-2018 JS Foundation and contributors, https://js.foundation
Copyright (c) 2011-2018 OpenJS Foundation and contributors, https://openjsf.org/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about to change 2018 to 2019.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for telling me what I missed! It's reflected.

@outsideris outsideris added area: documentation anything involving docs or mochajs.org area: website involving mochajs.org, but not necessarily involving docs labels Oct 4, 2019
HyunSangHan
HyunSangHan reviewed Oct 5, 2019
View reviewed changes
docs/README.md Outdated
:copyright: 2016-2018 [JS Foundation](https://js.foundation) and contributors.
:copyright: 2016-2018 [OpenJS Foundation](https://openjsf.org/) and contributors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it necessary to change the year from 2018 to 2019, too? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I reflected that too.

juergba
juergba reviewed Oct 6, 2019
View reviewed changes
.github/CODE_OF_CONDUCT.md Outdated
@@ -25,7 +25,7 @@ community, so you might not be communicating in someone else’s primary languag

Not all of us will agree all the time, but disagreement is no excuse for poor behavior and poor manners. We might all
experience some frustration now and then, but we cannot allow that frustration to turn into a personal attack. It’s important
to remember that a community where people feel uncomfortable or threatened is not a productive one. Members of the JS Foundation
to remember that a community where people feel uncomfortable or threatened is not a productive one. Members of the OpenJS Foundation
community should be respectful when dealing with other members as well as with people outside the JS Foundation community.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is another "JS Foundation".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 47, 48 the next ones.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I reflected that too.

LICENSE
@@ -1,6 +1,7 @@
(The MIT License)

Copyright (c) 2011-2018 JS Foundation and contributors, https://js.foundation
Copyright (c) 2011-2019 OpenJS Foundation and contributors, https://openjsf.org/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. This is legal, therefore quite sensitive stuff.
Is it still MIT license?
2011-2019: OpenJS Foundation exists since 2018?
This concerns legal issues and you have to be careful what you are changing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juergba I didn't know a legal issue.
How we descibe the copyright? "Since 2011" part needed?

Copyright (c) 2011-2019 OpenJS Foundation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. You could study OpenJSFoundation's homepage, or study repos of other packages, or ask jorydotcom or ask boneskull.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorydotcom
Do you know about this legal issue?
Copyright (c) 2011-2019 OpenJS Foundation or Copyright (c) 2019 OpenJS Foundation.
We don't know a legal issue.

MAINTAINERS.md

1. Active maintainers of Mocha
1. Prospective maintainers of Mocha
1. Anyone curious about how Mocha's maintainers maintain Mocha

The purpose of this document is to *describe our processes*. We want to avoid conflicts and confusion around "unwritten rules". In our opinion, the most straightforward way to address this is to *write them down*. This *also* happens to be the most straightforward way to change them!
The purpose of this document is to _describe our processes_. We want to avoid conflicts and confusion around "unwritten rules". In our opinion, the most straightforward way to address this is to _write them down_. This _also_ happens to be the most straightforward way to change them!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you changed all this? On my platform the result is the same for * and _.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe our markdown-linter changed this.

docs/README.md
@@ -23,7 +23,7 @@ _So you wanna build the site?_

## License

:copyright: 2016-2018 [JS Foundation](https://js.foundation) and contributors.
:copyright: 2016-2019 [OpenJS Foundation](https://openjsf.org/) and contributors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again I don't know, but OpenJS Foundation does exist since 2018?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 92.761% when pulling b7754f3 on leehwarang:issue/3971 into ec17f63 on mochajs:master.

@boneskull
Copy link
Member

Thanks! But ... we still don't have direction from the OpenJS Foundation on updating copyright notices, so we will need to hold off on this.

I think it's probably best to close this for now, and then re-open when we have the required information from the Foundation.

@boneskull boneskull closed this Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

@HyunSangHan HyunSangHan HyunSangHan left review comments

@juergba juergba juergba left review comments

Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org area: website involving mochajs.org, but not necessarily involving docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@leehwarang @jsf-clabot @coveralls @boneskull @outsideris @HyunSangHan @juergba