Throw well formatted error if file passed via argument cannot be found (closes #4047) #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
ref: #4047 |
outsideris
added
type: bug
|
Was this forgotten? |
juergba
reviewed
Feb 14, 2020
There was a problem hiding this comment.
@Agreon thank you
Your PR has two main issues:
- you check not only files set by the
--fileoption, but all test files for existence. - collect-files.js is not the correct place for this check, in
watchmode it would be called for each re-run.
I see that you have already deleted this PR's branch, I'm sorry. I will close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I added a simple loop that checks if files that are given through the
--fileargument are existing. If not an error message is display and the program exited to prevent them from being required later on.Alternate Designs
I thought about placing it in
run.jsbut the existings checks were all done somewhere more deep.collect-files()is used for the single- and watch-run. So we got the changes at one point.Why should this be in core?
It's a functionality already implemented similar in the core.
Benefits
Users get a better error message if they did something wrong.
Possible Drawbacks
None
Applicable issues
None