Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify invalid usage of done() #4101

Merged
merged 1 commit into from Nov 23, 2019
Merged

Commits on Nov 21, 2019

  1. docs: clarify invalid usage of done()

    When I first read 
    "anything else will cause a failed test"
    I considered that this might be a typo,
    and that this should say "a passed test"
    instead, because after all setting "no error"
    could mean "no error", right? I then understood
    that this sentence could also mean that
    "anything else is a programmer error", i.e. a bug
    and I was hoping that in _that_ case a clear
    error would be thrown.
    
    I tried things out and indeed found that the latter
    is the case
    
    > Error: done() invoked with non-Error: true
    
    This patch attempts to clarify that this is
    indeed all about a programmer error.
    jgehrcke committed Nov 21, 2019
    Copy the full SHA
    a3c24ca View commit details
    Browse the repository at this point in the history