Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .mocharc.cjs #4184

Closed
wants to merge 1 commit into from
Closed

Conversation

emma-borhanian
Copy link

@emma-borhanian emma-borhanian commented Feb 16, 2020

Description of the Change

This allows for "type": "module" in package.json while also using a
mocha config file, which was previously impossible.
See: https://nodejs.org/api/esm.html

Compare to jestjs/jest#9086

Alternate Designs

N/A

Why should this be in core?

N/A

Benefits

.mocharc.cjs works

Possible Drawbacks

N/A

Applicable issues

#4038

This allows for `"type": "module"` in package.json while also using a
mocha config file, which was previously impossible.
See: https://nodejs.org/api/esm.html

Compare to jestjs/jest#9086
@jsf-clabot
Copy link

jsf-clabot commented Feb 16, 2020

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 92.925% when pulling 559205f on emma-borhanian:config-cjs into ac12f2c on mochajs:master.

@emma-borhanian
Copy link
Author

Nvm somehow I missed it's in here #4038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants