[v5.2.x] Upgrade mkdirp to v0.5.5 #4224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayaddison Mocha@5 is almost two years old. We are not patching as far back and recommend to upgrade to Mocha@6 or Mocha@7. |
juergba
added
the
status: wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Benefits
npm auditand other vulnerability scanning noise for dependent projectsAlternate Designs
Replacing
mkdirpwithfs.mkdirSyncas included in mocha v2.6.3 via #4200 might also have been possible.That alternative approach does rely on nodejs v10.12.0, released 2018-10-10.
mocha v5.2.0 was released 2018-05-18 and states compatibility with node >= 4.0.
Applicable issues
Resolves #4220
Relates to #4204