Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test case for #4251 #4252

Merged
merged 1 commit into from Apr 25, 2020
Merged

add test case for #4251 #4252

merged 1 commit into from Apr 25, 2020

Conversation

boneskull
Copy link
Member

straightforward check for #4251. we really shouldn't need to do this; I hope someone created an issue in karma-mocha.

@boneskull
add test case for #4251
3969c99 
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 24, 2020
@boneskull boneskull self-assigned this Apr 24, 2020
@boneskull boneskull requested a review from juergba April 24, 2020 21:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.01% when pulling 3969c99 on boneskull/pull/4251 into 13e94b1 on master.

@juergba
Copy link
Member

juergba commented Apr 25, 2020

@boneskull I don't like this. If you think one of my PR is incomplete, then please review it accordingly.
But merging my incomplete PR and then fixing it yourself afterwards, is respectless.

@boneskull
Copy link
Member Author

no offense intended. I thought I was saving you the trouble! sometimes it is just quicker to merge things and then address it afterwards.

@boneskull
Copy link
Member Author

so, apologies, I can close this if you wish.

@juergba
Copy link
Member

juergba commented Apr 25, 2020

ok. Re closing: I don't know yet.

@juergba juergba merged commit 4c0231c into master Apr 25, 2020
@juergba juergba added this to the next milestone Apr 25, 2020
@juergba juergba deleted the boneskull/pull/4251 branch April 25, 2020 16:40
@juergba juergba added the landed-on-v7.1.x cherry-picked from master label Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees

@boneskull boneskull

Labels
landed-on-v7.1.x cherry-picked from master semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v7.1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boneskull @coveralls @juergba