Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 3840: --forbid-only doesn't recognize it.only when before crashes #4256

Merged
merged 19 commits into from May 12, 2020
Merged

Bug 3840: --forbid-only doesn't recognize it.only when before crashes #4256

merged 19 commits into from May 12, 2020

Commits on Apr 28, 2020

  1. add fixtures that result in it.only combined with --forbid-only bug

    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    c0c1dea View commit details
    Browse the repository at this point in the history

  2. adapt forbidonly test cases to cover it.only bug

    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    63d6144 View commit details
    Browse the repository at this point in the history

  3. check if forbid only option is set prior to marking a test only and t… 

    …hrow error
    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    2f0f134 View commit details
    Browse the repository at this point in the history

  4. change name of only test back to previous

    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    3c8af1b View commit details
    Browse the repository at this point in the history

  5. use custom assertion for expecting error in forbidOnly tests

    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    7d6110a View commit details
    Browse the repository at this point in the history

  6. remove empty line

    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    39e89fe View commit details
    Browse the repository at this point in the history

  7. use createUnsupportedError instead of throw new Error

    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    11d5fe1 View commit details
    Browse the repository at this point in the history

  8. use createUnsupportedError instead of throw new Error

    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    7015048 View commit details
    Browse the repository at this point in the history

  9. remove check if suite hasOnly and forbidOnly option is set as this is… 

    … done before runtime
    @arvidOtt
    arvidOtt committed Apr 28, 2020
    Copy the full SHA
    956cef2 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. implement markOnly instance method in suite class

    @arvidOtt
    arvidOtt committed May 5, 2020
    Copy the full SHA
    4b37e3c View commit details
    Browse the repository at this point in the history

  2. add unit test for suites markOnly method

    @arvidOtt
    arvidOtt committed May 5, 2020
    Copy the full SHA
    c2c8dc8 View commit details
    Browse the repository at this point in the history

  3. throw exception if --forbid-only option is set even if suite is not s… 

    …elected by grep
    @arvidOtt
    arvidOtt committed May 5, 2020
    Copy the full SHA
    f871782 View commit details
    Browse the repository at this point in the history

  4. adapt forbidOnly integration tests to check for failure if only suite… 

    … is not selected by grep
    @arvidOtt
    arvidOtt committed May 5, 2020
    Copy the full SHA
    336425a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. fix jsdocs of suite markonly

    @arvidOtt
    arvidOtt committed May 7, 2020
    Copy the full SHA
    cffc71a View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Revert "fix jsdocs of suite markonly" 

    This reverts commit cffc71a.
    @arvidOtt
    arvidOtt committed May 12, 2020
    Copy the full SHA
    419f584 View commit details
    Browse the repository at this point in the history

  2. Revert "adapt forbidOnly integration tests to check for failure if on… 

    …ly suite is not selected by grep"

This reverts commit 336425a.
    @arvidOtt
    arvidOtt committed May 12, 2020
    Copy the full SHA
    189b5cf View commit details
    Browse the repository at this point in the history

  3. Revert "throw exception if --forbid-only option is set even if suite … 

    …is not selected by grep"

This reverts commit f871782.
    @arvidOtt
    arvidOtt committed May 12, 2020
    Copy the full SHA
    053867f View commit details
    Browse the repository at this point in the history

  4. Revert "add unit test for suites markOnly method" 

    This reverts commit c2c8dc8.
    @arvidOtt
    arvidOtt committed May 12, 2020
    Copy the full SHA
    0834199 View commit details
    Browse the repository at this point in the history

  5. Revert "implement markOnly instance method in suite class" 

    This reverts commit 4b37e3c.
    @arvidOtt
    arvidOtt committed May 12, 2020
    Copy the full SHA
    3d21897 View commit details
    Browse the repository at this point in the history