Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vulnerability): update yargs-unparser to v1.6.1 #4338

Closed

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Jun 17, 2020

Requirements

See #4332 and #4340.

The problem is a vulnerability in lodash. See here https://snyk.io/test/npm/mocha/

With this PR we fixed the second vulnerability. The first one was already fixed with PR #4333.

Description of the Change

Update yargs-unparser to v1.6.1.
Before: https://snyk.io/test/npm/yargs-unparser/1.6.0
After: https://snyk.io/test/npm/yargs-unparser/1.6.1

@deleonio
Copy link
Contributor Author

Hello @juergba ,
I dont know, whats going wrong -- netlify/mocha/deploy-preview

Can you help me?

Thank you.

@coveralls
Copy link

coveralls commented Jun 17, 2020

Coverage Status

Coverage increased (+0.03%) to 93.795% when pulling e8749b1 on martinoppitz:fix/vulnerability-issue-4332 into 9d4a8ec on mochajs:master.

@boneskull
Copy link
Member

  1. revert CHANGELOG.md
  2. rebase onto master

@deleonio deleonio force-pushed the fix/vulnerability-issue-4332 branch from a215e8d to b6b3dea Compare June 18, 2020 18:43
@deleonio
Copy link
Contributor Author

@boneskull Done.

@deleonio
Copy link
Contributor Author

How we can replay the PR checke?

@deleonio deleonio force-pushed the fix/vulnerability-issue-4332 branch from 3ee6e88 to d84713b Compare June 25, 2020 20:58
@deleonio deleonio closed this Jun 27, 2020
@deleonio deleonio deleted the fix/vulnerability-issue-4332 branch June 27, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants