Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade debug module because of Vulnerability #4533 #4544

Closed
wants to merge 1 commit into from

Conversation

outsideris
Copy link
Member

Description of the Change

debug@4.20 has a low-severity ReDos regression, and it fixed in 4.3.1.
A deprecation warning is printed when users install mocha.

Our nested dependencies has debug@4.1.1. But they are devDependencies.

Why should this be in core?

I think Mocha isn't vulnerable to it.
But we don't want users to see this kind of security warnings.

Applicable issues

Fix #4533

Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris outsideris added type: chore generally involving deps, tooling, configuration, etc. dependencies Pull requests that update a dependency file area: security involving vulnerabilities labels Jan 7, 2021
@outsideris outsideris self-assigned this Jan 8, 2021
@outsideris
Copy link
Member Author

closed by #4556

@outsideris outsideris closed this Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: security involving vulnerabilities dependencies Pull requests that update a dependency file type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug@4.2.0 used in Mocha is creating deprecation warnings
1 participant