Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include .cause stacks in the error stack traces #4829

Merged
merged 9 commits into from
Mar 4, 2024
Merged

feat: include .cause stacks in the error stack traces #4829

merged 9 commits into from
Mar 4, 2024

Commits on Feb 27, 2024

  1. Append the cause stacks to the main stack trace 

    It would be great to get the full error stack chain for errors with causes, especially as all current browsers and Node.js >=16 supports it, see eg https://v8.dev/features/error-cause and https://dev.to/voxpelli/pony-cause-1-0-error-causes-2l2o

Eg. `pino` merged support for this as well: pinojs/pino-std-serializers#78
    @voxpelli
    voxpelli committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    62671e9 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @voxpelli
    voxpelli committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    86f0560 View commit details
    Browse the repository at this point in the history

  3. Skip some string concatenation

    @voxpelli
    voxpelli committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a627c6a View commit details
    Browse the repository at this point in the history

  4. Don't export needlessly + improve docs

    @voxpelli
    voxpelli committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    58300c4 View commit details
    Browse the repository at this point in the history

  5. Improved recursive filtering

    @voxpelli
    voxpelli committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    de2dfe4 View commit details
    Browse the repository at this point in the history

  6. Added loop protection

    @voxpelli
    voxpelli committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ba45e65 View commit details
    Browse the repository at this point in the history

  7. Same logic for "message" in cause trail as in top

    @voxpelli
    voxpelli committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    0ec8b7d View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
    @voxpelli @JoshuaKGoldberg
    voxpelli and JoshuaKGoldberg committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    04f7008 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Revert "Apply suggestions from code review" 

    This reverts commit 04f7008.
    @voxpelli
    voxpelli committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    571ac7c View commit details
    Browse the repository at this point in the history