Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add error handling for nonexistent file case with --file option #5086

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

feat: Add error handling for nonexistent file case with --file option #5086

wants to merge 20 commits into from

Commits on Jan 24, 2024

  1. feat: handle nonexistent files passed to --file 

    - added error handling when using the --file flag to do it the way
  --require does
- added a test to assert that we throw the same type of error
    @khoaHyh
    khoaHyh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    bd47d79 View commit details
    Browse the repository at this point in the history

  2. refactor: remove path.resolve() 

    - require.resolve() by Node.js follows a Node.js module resolution algo
  which includes checking if the resolved path actually exists on the
  file system.
    @khoaHyh
    khoaHyh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4aad184 View commit details
    Browse the repository at this point in the history

  3. add comment to new code in collect-files.js

    @khoaHyh
    khoaHyh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    8983b84 View commit details
    Browse the repository at this point in the history

  4. fix: add back absolute path resolving

    @khoaHyh
    khoaHyh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b6d6dc2 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. refactor: log warning and remove call stack

    @khoaHyh
    khoaHyh committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9b3d5d2 View commit details
    Browse the repository at this point in the history

  2. revert changes to bin/mocha.js

    @khoaHyh
    khoaHyh committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    645e0b0 View commit details
    Browse the repository at this point in the history

  3. improve test case

    @khoaHyh
    khoaHyh committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0e1e84a View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Merge branch 'master' into issue/4047

    @khoaHyh
    khoaHyh committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    9685b82 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'master' into issue/4047

    @khoaHyh
    khoaHyh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f8aedff View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Merge branch 'master' into issue/4047

    @khoaHyh
    khoaHyh committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    a6bdef4 View commit details
    Browse the repository at this point in the history

  2. throw error and have handler work with it

    @khoaHyh
    khoaHyh committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    909834d View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. change collectFiles to return object

    @khoaHyh
    khoaHyh committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    cf69df1 View commit details
    Browse the repository at this point in the history

  2. clean up

    @khoaHyh
    khoaHyh committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b905d21 View commit details
    Browse the repository at this point in the history

  3. exit mocha immediately on missing file

    @khoaHyh
    khoaHyh committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ea092be View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. new log message

    @khoaHyh
    khoaHyh committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6d4170e View commit details
    Browse the repository at this point in the history

  2. add tests

    @khoaHyh
    khoaHyh committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    bad240d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issue/4047

    @khoaHyh
    khoaHyh committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    21e566d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue/4047

    @khoaHyh
    khoaHyh committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    dce26f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'master' into issue/4047

    @khoaHyh
    khoaHyh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4c9f318 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge remote-tracking branch 'upstream/master' into issue/4047

    @khoaHyh
    khoaHyh committed May 29, 2024
    Configuration menu
    Copy the full SHA
    1a9f155 View commit details
    Browse the repository at this point in the history