Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec-reporter prints retries #5099

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

CheadleCheadle
Copy link

@CheadleCheadle CheadleCheadle commented Feb 22, 2024

PR Checklist

Overview

I've implemented a function called logRetries() which displays the number of the current retry along with the total number of retries, provided that the total number of retries is greater than zero. This output is formatted below the test title and highlighted in yellow as requested for ecosystem consistency. I would greatly appreciate any feedback on this addition!
Example:
retries

@coveralls
Copy link

Coverage Status

coverage: 94.346% (+0.01%) from 94.335%
when pulling b5d4d68 on CheadleCheadle:spec-reporter-retries
into b88978d on mochajs:master.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello again! 😄

Left some thoughts - I'm excited to see this come in!

lib/reporters/spec.js Outdated Show resolved Hide resolved
lib/reporters/spec.js Outdated Show resolved Hide resolved
bin/mocha.js Outdated Show resolved Hide resolved
lib/reporters/spec.js Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP - more information needed label Mar 4, 2024
Copy link
Author

@CheadleCheadle CheadleCheadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored to include retry on same line(retry x1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author waiting on response from OP - more information needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the spec reporter report retries?
3 participants