Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

Running apply-types twice makes the project explode #36

Open
MadaraUchiha opened this issue Mar 21, 2018 · 1 comment
Open

Running apply-types twice makes the project explode #36

MadaraUchiha opened this issue Mar 21, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@MadaraUchiha
Copy link
Contributor

Running apply-types twice makes it attempt to actually apply the types twice.

Proposal: remove the collected-types.json file after running apply-types once. (Or something similar)

#goodnessSquad

@urish
Copy link
Collaborator

urish commented Mar 23, 2018

Seems like #34 can fix that - if we update collected-types whenever we apply a type, and mark this type as applied (or simply remove it from the list), it should do the trick.

Another thing we can do is to save the hash of each of the source file inside collected-types.json, so we can detect if the files have been changed since we collected the types (and warn the user about that).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants