Skip to content

Refactor Container #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Refactor Container #1360

merged 3 commits into from
Feb 27, 2024

Conversation

ghostwriter
Copy link
Member

This patch Improves performance and readability without changing functionality.

  • library/Mockery/Container.php

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added Performance for improvements or optimizations related to performance Refactor for code refactoring or restructuring without changes to functionality labels Feb 27, 2024
@ghostwriter ghostwriter added this to the 1.6.8 milestone Feb 27, 2024
@ghostwriter ghostwriter self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 77.96%. Comparing base (8b8ac32) to head (7b131df).

Additional details and impacted files
@@             Coverage Diff              @@
##              1.6.x    #1360      +/-   ##
============================================
+ Coverage     77.82%   77.96%   +0.13%     
+ Complexity     1025     1024       -1     
============================================
  Files            76       76              
  Lines          2616     2646      +30     
============================================
+ Hits           2036     2063      +27     
- Misses          580      583       +3     
Files Coverage Δ
library/Mockery/Container.php 91.48% <90.74%> (-0.22%) ⬇️

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter merged commit 594bd2b into 1.6.x Feb 27, 2024
@ghostwriter ghostwriter deleted the refactor/update-container branch February 27, 2024 20:39
@ghostwriter ghostwriter mentioned this pull request Mar 12, 2024
@ghostwriter ghostwriter added the Patch Backwards compatible bug fixes and improvements label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Backwards compatible bug fixes and improvements Performance for improvements or optimizations related to performance Refactor for code refactoring or restructuring without changes to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant