Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly Handle Initialization Errors and Ensure Accurate 'Failed Expectation' Messages #1423

Merged
merged 1 commit into from
May 19, 2024
Merged

Properly Handle Initialization Errors and Ensure Accurate 'Failed Expectation' Messages #1423

merged 1 commit into from
May 19, 2024

Conversation

hschletz
Copy link
Contributor

@hschletz hschletz commented May 18, 2024 •
edited by ghostwriter

This patch resolves #1132, via the following changes:

  • Switching from Exception to Throwable in Mockery's TryCatch Block

@ghostwriter ghostwriter self-assigned this May 19, 2024
@ghostwriter ghostwriter changed the title Fix #1132 Properly Handle Initialization Errors and Ensure Accurate 'Failed Expectation' Messages May 19, 2024
@ghostwriter ghostwriter added this to the 1.6.13 milestone May 19, 2024
@ghostwriter ghostwriter mentioned this pull request May 19, 2024
Merged
@ghostwriter
Copy link
Member

Hey @hschletz,

Your solution is good, but it’s missing a test.

GitHub is not allowing me to make changes to this PR 🤷🏾‍♂️, I will add a test in #1424.

Thank you for your contribution!

@ghostwriter ghostwriter merged commit 1b81af7 into mockery:1.6.x May 19, 2024
23 checks passed
ghostwriter added a commit that referenced this pull request May 19, 2024
@ghostwriter @SHSP-DavidTombs
Add test and fixture for PR #1423 (#1424)
8acb939 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Co-authored-by: David Tombs <55712554+shsp-davidtombs@users.noreply.github.com>
@ghostwriter ghostwriter added Patch Backwards compatible bug fixes and improvements Fixed for bug fixes or error corrections labels May 19, 2024
@hschletz hschletz deleted the patch-1 branch May 24, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghostwriter ghostwriter

Labels
Fixed for bug fixes or error corrections Patch Backwards compatible bug fixes and improvements
Projects
None yet
Milestone
1.6.13
Development

Successfully merging this pull request may close these issues.

"Typed property must not be accessed before initialization" hides true error
2 participants
@hschletz @ghostwriter