Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional matchers #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tschuchortdev
Copy link

Adds some additional matchers like not, or leq. I couldn't be bothered to write tests because the code is so incredibly simple.

Base automatically changed from 2.x to main January 18, 2021 03:46
@perkss
Copy link

perkss commented Mar 2, 2022

Any plans to put this in?

@TWiStErRob
Copy link
Contributor

@tschuchortdev the code is simple, but it's still code, and the tests would protect it from breaking in the future. For example, if the functions get reordered, and accidentally change bodies or something we don't know yet. Verifying a basic requirement that the function delegates to the right one (by validating what it does e.g. tests would be different for lt and leq).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants