Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#488: Change kotlinOptions.jvmTarget to VERSION_1_8 #493

Closed
wants to merge 1 commit into from

Conversation

naitaku
Copy link

@naitaku naitaku commented Sep 19, 2023

This commit addresses issue #488, where Android projects were encountering a build failure with the error message: "Cannot inline bytecode built with JVM target 11."
The issue was resolved by adjusting the 'jvmTarget' to 'VERSION_1_8,' ensuring compatibility with Android projects.

  • Can you back your code up with tests?
  • Add mockito-kotlin dependency with testImplementation and androidTestImplementation to an Android project, and mock function works.

@TimvdLippe
Copy link
Contributor

Mockito 5 no longer supports Java 8. Therefore, I don't think we should do that for mockito-kotlin either, should we?

@naitaku
Copy link
Author

naitaku commented Sep 21, 2023

My understanding is that mockito-core 5.x no longer supports Java 8, and 'jvmTarget' should be set to 'VERSION_11.'
I'll close this PR.

@naitaku naitaku closed this Sep 21, 2023
@naitaku naitaku deleted the fix488 branch September 21, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants