Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suppress instrumentation exceptions #1012

Merged

Conversation

raphw
Copy link
Member

@raphw raphw commented Mar 30, 2017

Rather propagate them to mock maker that attempts instrumentation. Addresses #1005.

…to mock maker that attempts instrumentation. Addresses #1005
@codecov-io
Copy link

codecov-io commented Mar 30, 2017

Codecov Report

Merging #1012 into release/2.x will decrease coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/2.x    #1012      +/-   ##
=================================================
- Coverage          86.86%   86.82%   -0.05%     
  Complexity          2290     2290              
=================================================
  Files                287      287              
  Lines               5801     5806       +5     
  Branches             684      685       +1     
=================================================
+ Hits                5039     5041       +2     
- Misses               571      573       +2     
- Partials             191      192       +1
Impacted Files Coverage Δ Complexity Δ
...al/creation/bytebuddy/InlineBytecodeGenerator.java 90.62% <50%> (-2.79%) 21 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b98d71...503a291. Read the comment docs.

@TimvdLippe
Copy link
Contributor

@raphw fix seem fine by me, but it does not fix #1005 right?

@raphw
Copy link
Member Author

raphw commented Apr 18, 2017

No, it does not fix it. Some classes are broken when it comes to their internal structure. I do not see how we can instrument classes that were messed up by ProGuard, unfortunately.

@TimvdLippe TimvdLippe merged commit 950e440 into release/2.x Apr 18, 2017
@TimvdLippe TimvdLippe deleted the better-exceptions-for-instrumentation-errors branch April 18, 2017 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants