#1900 Configure mocks for annotation interfaces with default values from annotation #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues from annotation
ghenzler
commented
Apr 7, 2020
|
|
||
| if(typeToMock.isAnnotation()) { | ||
| configureMockWithAnnotationDefaults(typeToMock, mock); | ||
| } |
There was a problem hiding this comment.
This works well but I'm not sure if this is the best position to hook in this functionality - I'm happy to adjust if there is a better position to perform this.
Codecov Report
@@ Coverage Diff @@
## release/3.x #1901 +/- ##
=================================================
- Coverage 86.67% 86.66% -0.02%
- Complexity 2526 2530 +4
=================================================
Files 318 318
Lines 6650 6660 +10
Branches 832 834 +2
=================================================
+ Hits 5764 5772 +8
- Misses 685 687 +2
Partials 201 201
Continue to review full report at Codecov.
|
ST-DDT
approved these changes
May 13, 2020
| @@ -62,6 +63,11 @@ public boolean isTypeMockable(Class<?> typeToMock) { | |||
| MockCreationSettings<T> creationSettings = impl.build(typeToMock); | |||
| T mock = createMock(creationSettings); | |||
| mockingProgress().mockingStarted(mock, creationSettings); | |||
|
|
|||
| if(typeToMock.isAnnotation()) { | |||
There was a problem hiding this comment.
Suggested change
| if(typeToMock.isAnnotation()) { | |
| if (typeToMock.isAnnotation()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1900