Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gradle 6 #1948

Merged
merged 8 commits into from Jun 16, 2020
Merged

Update gradle 6 #1948

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
60952f8
Upgrade to Gradle 6
TimvdLippe Jun 15, 2020
07e6a6a
Remove commented plugin
TimvdLippe Jun 15, 2020
67cba9b
Move checksum computation out of Gradle
TimvdLippe Jun 15, 2020
e1b1fd2
Run reproducibility check as a separate Travis build
TimvdLippe Jun 15, 2020
d8fcdb1
Fix code coverage
TimvdLippe Jun 16, 2020
34d7f18
Fix disabling of projects for the coverage task
TimvdLippe Jun 16, 2020
5b88306
Fix exclusion of errorprone subproject
TimvdLippe Jun 16, 2020
4683c77
Reverse logic in coverage.gradle
TimvdLippe Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion .travis.yml
View file
Open in desktop
Expand Up @@ -34,6 +34,9 @@ matrix:
env: SKIP_RELEASE=true
- jdk: openjdk11
env: SKIP_RELEASE=true MOCK_MAKER=mock-maker-inline
- jdk: openjdk8
script: ./check_reproducibility.sh
Comment on lines +37 to +38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- jdk: openjdk8
script: ./check_reproducibility.sh
- name: "Check reproducibility"
jdk: openjdk8
script: ./check_reproducibility.sh

Taking a look in Travis right now, it looks like "just" another Jdk 8 build and this would allow people to identify this particular job at a glance if it starts failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to do this in a follow-up, as we can do some more cleanup of the Travis tasks. Thanks for the suggestion 😄

after_success: true

branches:
#Don't build tags
Expand All @@ -50,7 +53,7 @@ script:
# We are using && below on purpose
# ciPerformRelease must run only when the entire build has completed
# This guarantees that no release steps are executed when the build or tests fail
- ./gradlew spotlessCheck && ./gradlew build idea -s && ./check_reproducibility.sh && ./gradlew ciPerformRelease
- ./gradlew spotlessCheck && ./gradlew build idea -s && ./gradlew ciPerformRelease

after_success:
#Generates coverage report:
Expand Down