Revert "Update objenesis to 3.1"

[TimvdLippe]

Reverts #1998

See #2007 for more info on how this breaks Android

Fixes #2007

[codecov-commenter]

Codecov Report

Merging #2009 into release/3.x will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/3.x    #2009   +/-   ##
==============================================
  Coverage          84.90%   84.90%           
  Complexity          2692     2692           
==============================================
  Files                324      324           
  Lines               8161     8161           
  Branches             972      972           
==============================================
  Hits                6929     6929           
  Misses               964      964           
  Partials             268      268           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bdc24...5fa2a74. Read the comment docs.

[raphw]

Annoying but probably the best option. Maybe we can explicitly downgrade Objenesis in the mockito-android artifact instead?

[raphw]

Wondering if we can just downgrade the version in mockito-android? What errors did the new Objenesis fix? Maybe it's required to work with the newest Java versions?

[raphw]

Wondering if we can just downgrade the version in mockito-android? What errors did the new Objenesis fix? Maybe it's required to work with the newest Java versions?

[TimvdLippe]

Hm yes that could work. I can test that out tomorrow.

[kozaxinan]

This issue still blocks android projects to use latest mockito. Is further work planned on this PR? If not I can provide a different PR with requested fix.

[TimvdLippe]

I have not yet had the time to do an analysis on this issue. If you have a proposed fix and you can confirm it works, I would be very happy to review it! Thanks in advance 😄

[raphw]

Just to be sure: did you try to downgrade Objenesis explicitly? Are you using mockito-android?

[kozaxinan]

We downgraded objenesis version with gradle dependency resolutions.

configurations.configureEach {
    resolutionStrategy.eachDependency { details ->
     if (details.requested.group == 'org.objenesis') {
        details.useVersion '2.6'
      } 
    }
  }

This worked well. We have mockito-android too, but in most case we also have mockito-core with com.nhaarman.mockitokotlin2:mockito-kotlin

I will build a mockito-android with older objenesis and check the fix. (It might take time)

[raphw]

Thank you.

My favorit solution would be to fix the version for Android-specific artifacts but use the latest for core to support newer Java versions.

[kozaxinan]

I have experimented downgrading objenesis just in mockito-android. When mockito-android is used with mockito-kotln, gradle uses higher version from mockito-kotlin. A solution is suggested in #2024.

[TimvdLippe]

This was fixed in #2024