Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exclude synthetic constructors from instrumentation. Fixes #2040. #2046

Merged
merged 1 commit into from Sep 17, 2020

Conversation

raphw
Copy link
Member

@raphw raphw commented Sep 16, 2020

Byte Buddy does exclude synthetic members by default as they normally provide necessary infrastructure outside of business logic (e.g. bridge methods). For constructor instrumentation, it is however crucial that no code is called during mock creation and that fields are copied during spy creation.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020

Codecov Report

Merging #2046 into release/3.x will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #2046   +/-   ##
==============================================
  Coverage          84.89%   84.90%           
  Complexity          2704     2704           
==============================================
  Files                325      325           
  Lines               8204     8206    +2     
  Branches             979      979           
==============================================
+ Hits                6965     6967    +2     
  Misses               968      968           
  Partials             271      271           
Impacted Files Coverage Δ Complexity Δ
.../internal/creation/bytebuddy/MockMethodAdvice.java 77.90% <75.00%> (+0.06%) 23.00 <0.00> (ø)
...al/creation/bytebuddy/InlineBytecodeGenerator.java 92.75% <100.00%> (+0.03%) 38.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ae6cf...4a40f58. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants