Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update animal-sniffer plugin #2088

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Nov 5, 2020

Updates the animal-sniffer plugin.

The new version fixes xvik/gradle-animalsniffer-plugin#25 which caused build failures on Windows because class files were processed in an incorrect order causing the nested class InlineByteBuddyMockMaker$1 (which has the forbidden access) to be processed before the enclosing class which has the @SuppressSignatureCheck annotation. Previously the tests failed for me with:

[Undefined reference (android-api-level-24-7.0_r2)] org.mockito.internal.creation.bytebuddy.(InlineByteBuddyMockMaker.java:507)
  >> java.lang.instrument.Instrumentation

[Undefined reference (android-api-level-24-7.0_r2)] org.mockito.internal.creation.bytebuddy.(InlineByteBuddyMockMaker.java:507)
  >> boolean java.lang.instrument.Instrumentation.isModifiableClass(Class)

(This problem has also been mentioned in the description of #2024)

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #2088 into release/3.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #2088   +/-   ##
==============================================
  Coverage          84.80%   84.80%           
  Complexity          2716     2716           
==============================================
  Files                325      325           
  Lines               8266     8266           
  Branches             988      988           
==============================================
  Hits                7010     7010           
  Misses               982      982           
  Partials             274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d44781...e9edfa8. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting the issue upstream and getting it fixed so quickly!

@TimvdLippe TimvdLippe merged commit 252d99d into mockito:release/3.x Nov 5, 2020
@Marcono1234 Marcono1234 deleted the marcono1234/animal-sniffer-plugin-update branch November 5, 2020 13:26
@Marcono1234
Copy link
Contributor Author

No problem, but you will have to thank @xvik (the author of the plugin) for their fast response, I did not urge them 😄

holubec-petr pushed a commit to holubec-petr/mockito that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants