Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed order of verify parameters #2179

Merged
merged 1 commit into from Jan 16, 2021
Merged

Fix reversed order of verify parameters #2179

merged 1 commit into from Jan 16, 2021

Conversation

bohni
Copy link
Contributor

@bohni bohni commented Jan 16, 2021

For consistency the parameters of the method
MockedStatic.verify(VerificationMode, Verification)
have been swapped to
MockedStatic.verify(Verification, VerificationMode)
as this order is already used in
Mockito.verify(T, VerificationMode)

Fixes: #2173

check list

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

For consistency the parameters of the method
MockedStatic.verify(VerificationMode, Verification)
have been swapped to
MockedStatic.verify(Verification, VerificationMode)
as this order is already used in
Mockito.verify(T, VerificationMode)

Fixes: #2173
@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #2179 (3e37299) into release/3.x (79f06ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #2179   +/-   ##
==============================================
  Coverage          84.87%   84.87%           
- Complexity          2721     2722    +1     
==============================================
  Files                325      325           
  Lines               8278     8280    +2     
  Branches             989      989           
==============================================
+ Hits                7026     7028    +2     
  Misses               981      981           
  Partials             271      271           
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/mockito/MockedStatic.java 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
...in/java/org/mockito/internal/MockedStaticImpl.java 79.22% <100.00%> (+0.55%) 12.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f06ba...3e37299. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Unify order of parameters
3 participants