Fix most Gradle warnings in build #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AbstractArchiveTask.extension property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the archiveExtension property instead. See https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:extension for more details. at org.gradle.api.tasks.bundling.AbstractArchiveTask.getExtension(AbstractArchiveTask.java:378) at org.gradle.api.tasks.bundling.Jar_Decorated.getExtension(Unknown Source) at org.gradle.api.tasks.bundling.Jar_Decorated.getProperty(Unknown Source) at java_publication_3m1q2um515b0jc9w5l4jkv2vf$_run_closure3$_closure11$_closure13$_closure16$_closure17.doCall(P:\projects\contrib\github-mockito\gradle\java-publication.gradle:61) at java_publication_3m1q2um515b0jc9w5l4jkv2vf$_run_closure3$_closure11$_closure13$_closure16.doCall(P:\projects\contrib\github-mockito\gradle\java-publication.gradle:57) at java_publication_3m1q2um515b0jc9w5l4jkv2vf$_run_closure3$_closure11$_closure13.doCall(P:\projects\contrib\github-mockito\gradle\java-publication.gradle:53) at java_publication_3m1q2um515b0jc9w5l4jkv2vf$_run_closure3$_closure11.doCall(P:\projects\contrib\github-mockito\gradle\java-publication.gradle:41) at java_publication_3m1q2um515b0jc9w5l4jkv2vf$_run_closure3.doCall(P:\projects\contrib\github-mockito\gradle\java-publication.gradle:40) at java_publication_3m1q2um515b0jc9w5l4jkv2vf.run(P:\projects\contrib\github-mockito\gradle\java-publication.gradle:39) at java_library_31pwb6uziesoanbjna4tijtgv.run(P:\projects\contrib\github-mockito\gradle\java-library.gradle:8) at build_e6jjcbuu9ezmj4rzb0cym1acv.run(P:\projects\contrib\github-mockito\build.gradle:39)
The AbstractArchiveTask.version property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the archiveVersion property instead. See https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:version for more details. at org.gradle.api.tasks.bundling.AbstractArchiveTask.getVersion(AbstractArchiveTask.java:334) at org.gradle.api.tasks.bundling.Jar_Decorated.getVersion(Unknown Source) at osgi_1s7hu8z26iat6hd1sfy12d5of$_run_closure1$_closure2.doCall(P:\projects\contrib\github-mockito\gradle\mockito-core\osgi.gradle:6) at osgi_1s7hu8z26iat6hd1sfy12d5of$_run_closure1.doCall(P:\projects\contrib\github-mockito\gradle\mockito-core\osgi.gradle:5) at osgi_1s7hu8z26iat6hd1sfy12d5of.run(P:\projects\contrib\github-mockito\gradle\mockito-core\osgi.gradle:3) at build_e6jjcbuu9ezmj4rzb0cym1acv.run(P:\projects\contrib\github-mockito\build.gradle:44)
The AbstractArchiveTask.version property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the archiveVersion property instead. See https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:version for more details. at org.gradle.api.tasks.bundling.AbstractArchiveTask.getVersion(AbstractArchiveTask.java:334) at org.gradle.api.tasks.bundling.Jar_Decorated.getVersion(Unknown Source) at junit_jupiter_eg2xy6r7a4uptto82iioip1km$_run_closure3$_closure7.doCall(P:\projects\contrib\github-mockito\subprojects\junit-jupiter\junit-jupiter.gradle:23) at junit_jupiter_eg2xy6r7a4uptto82iioip1km$_run_closure3.doCall(P:\projects\contrib\github-mockito\subprojects\junit-jupiter\junit-jupiter.gradle:22) at junit_jupiter_eg2xy6r7a4uptto82iioip1km.run(P:\projects\contrib\github-mockito\subprojects\junit-jupiter\junit-jupiter.gradle:20)
The Report.enabled property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the required property instead. See https://docs.gradle.org/7.6/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled for more details. at org.gradle.api.reporting.internal.SimpleReport.setEnabled(SimpleReport.java:112) at org.gradle.api.reporting.internal.TaskGeneratedSingleFileReport_Decorated.setEnabled(Unknown Source) at org.gradle.api.reporting.internal.TaskGeneratedSingleFileReport_Decorated.enabled(Unknown Source) at org.gradle.api.reporting.internal.TaskGeneratedSingleFileReport_Decorated$enabled.call(Unknown Source) at coverage_bdrf6ncoyqn26tscdjn3v6kje$_run_closure1$_closure4.doCall(P:\projects\contrib\github-mockito\gradle\root\coverage.gradle:38 at coverage_bdrf6ncoyqn26tscdjn3v6kje$_run_closure1.doCall(P:\projects\contrib\github-mockito\gradle\root\coverage.gradle:37) at coverage_bdrf6ncoyqn26tscdjn3v6kje.run(P:\projects\contrib\github-mockito\gradle\root\coverage.gradle:1) at build_e6jjcbuu9ezmj4rzb0cym1acv.run(P:\projects\contrib\github-mockito\build.gradle:41)
The Report.enabled property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the required property instead. See https://docs.gradle.org/7.6/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled for more details. at org.gradle.api.reporting.internal.SimpleReport.setEnabled(SimpleReport.java:112) at org.gradle.api.reporting.internal.TaskGeneratedSingleFileReport_Decorated.setEnabled(Unknown Source) at org.gradle.api.reporting.internal.TaskGeneratedSingleFileReport_Decorated.enabled(Unknown Source) at org.gradle.api.reporting.internal.TaskGeneratedSingleFileReport_Decorated$enabled.call(Unknown Source) at java_library_31pwb6uziesoanbjna4tijtgv$_run_closure3$_closure5.doCall(P:\projects\contrib\github-mockito\gradle\java-library.gradle:33) at java_library_31pwb6uziesoanbjna4tijtgv$_run_closure3.doCall(P:\projects\contrib\github-mockito\gradle\java-library.gradle:32) at build_e6jjcbuu9ezmj4rzb0cym1acv$_run_closure1.doCall(P:\projects\contrib\github-mockito\build.gradle:77) at build_e6jjcbuu9ezmj4rzb0cym1acv.run(P:\projects\contrib\github-mockito\build.gradle:50)
…isn't recommended. Adding a Configuration as a dependency is a confusing behavior which isn't recommended. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. If you're interested in inheriting the dependencies from the Configuration you are adding, you should use Configuration#extendsFrom instead. See https://docs.gradle.org/7.6/dsl/org.gradle.api.artifacts.Configuration.html#org.gradle.api.artifacts.Configuration:extendsFrom(org.gradle.api.artifacts.Configuration[]) for more details. at org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.doAdd(DefaultDependencyHandler.java:181) at org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler$DirectDependencyAdder.add(DefaultDependencyHandler.java:444) at org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler$DirectDependencyAdder.add(DefaultDependencyHandler.java:439) at build_e6jjcbuu9ezmj4rzb0cym1acv$_run_closure3.doCall(P:\projects\contrib\github-mockito\build.gradle:96) at build_e6jjcbuu9ezmj4rzb0cym1acv.run(P:\projects\contrib\github-mockito\build.gradle:87)
TWiStErRob
commented
Feb 7, 2023
TWiStErRob
commented
Feb 7, 2023
Codecov ReportBase: 85.65% // Head: 85.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
=========================================
Coverage 85.65% 85.65%
Complexity 2847 2847
=========================================
Files 325 325
Lines 8623 8623
Branches 1060 1060
=========================================
Hits 7386 7386
Misses 964 964
Partials 273 273 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: reduce Gradle build using old approaches and prepare for upcoming breaking changes.
Originally on
mainthere were warnings, these are hidden because the default Gradle behavior is to hide them, but they will break at on point.To see them in all their glory, run
./gradlew --warning-mode=all --stacktrace.gradlew --warning-mode=allonmainNote that some warnings don't show up here that have been fixed, because they're deduplicated by Gradle. Gradle 8 will solve this, but right now we have to fix one to see one.
gradlew --warning-mode=allon this PRRemaining problems with
gradlew build --warning-mode=all --stacktraceInvidiual problems and their fixes.
GitHub doesn't support >65536 character comment 😅, so will post them separately as conversations on the relevant lines.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant