Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2934 throw exception on multiple matches by type if cannot be reduce… #2942

Merged

Conversation

jfrantzius
Copy link
Contributor

Fixes #2934 : throw exception on multiple matches by type if cannot be reduced to single match

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (74c811a) 85.68% compared to head (738ab00) 85.68%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2942   +/-   ##
=========================================
  Coverage     85.68%   85.68%           
- Complexity     2861     2864    +3     
=========================================
  Files           325      325           
  Lines          8682     8696   +14     
  Branches       1071     1074    +3     
=========================================
+ Hits           7439     7451   +12     
- Misses          966      967    +1     
- Partials        277      278    +1     
Impacted Files Coverage Δ
...ion/injection/filter/TypeBasedCandidateFilter.java 93.65% <100.00%> (+0.66%) ⬆️
...java/org/mockito/internal/exceptions/Reporter.java 91.06% <100.00%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jfrantzius
Copy link
Contributor Author

Hi @TimvdLippe , WDYT?

@jfrantzius
Copy link
Contributor Author

@TimvdLippe Is there a way for me to restart that build, except for a new commit?
image

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good addition!

@TimvdLippe TimvdLippe merged commit 393f0a1 into mockito:main Mar 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature suggestion: TerminalMockCandidateFilter should report error when more than one candidate left
3 participants