Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassCastException #2962

Merged
merged 2 commits into from Apr 9, 2023
Merged

Fix ClassCastException #2962

merged 2 commits into from Apr 9, 2023

Conversation

jfrantzius
Copy link
Contributor

@jfrantzius jfrantzius commented Apr 3, 2023

Adds support for concrete classes with parameterized super-classes.
Fixes #2958

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 95.34% and project coverage change: +0.03 🎉

Comparison is base (f9fbf50) 85.70% compared to head (f6eecf1) 85.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2962      +/-   ##
============================================
+ Coverage     85.70%   85.74%   +0.03%     
- Complexity     2865     2870       +5     
============================================
  Files           325      325              
  Lines          8696     8713      +17     
  Branches       1074     1076       +2     
============================================
+ Hits           7453     7471      +18     
  Misses          966      966              
+ Partials        277      276       -1     
Impacted Files Coverage Δ
...ion/injection/filter/TypeBasedCandidateFilter.java 96.25% <95.34%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jfrantzius
Copy link
Contributor Author

@TimvdLippe WDYT?

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@TimvdLippe TimvdLippe merged commit 84a5eee into mockito:main Apr 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException when combining InjectMocks with generified Mock field
3 participants