Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a variant of assertArg that works well with checked exceptions #2991

Merged
merged 6 commits into from May 6, 2023

Conversation

nicolas-ot
Copy link
Contributor

@nicolas-ot nicolas-ot commented Apr 26, 2023

fixes: #2982

  • add new FunctionalInterface ThrowingConsumer<T> extends Consumer<T>
  • add variant of assertArg that takes a ThrowingConsumer rather than a Consumer

I might be biting more than I can chew here, but here goes. My first PR here and I am very new to the whole open source in general, so feedbacks are most appreciated.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@nicolas-ot nicolas-ot marked this pull request as ready for review April 27, 2023 08:57
@nicolas-ot
Copy link
Contributor Author

hey @TimvdLippe , you might have missed this PR.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 6e0c228 into mockito:main May 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a variant of assertArg that works well with checked exceptions
2 participants